Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] E2e Tests for Notebook Examples #2417

Open
5 tasks
Electronic-Waste opened this issue Sep 2, 2024 · 9 comments · May be fixed by #2448
Open
5 tasks

[Test] E2e Tests for Notebook Examples #2417

Electronic-Waste opened this issue Sep 2, 2024 · 9 comments · May be fixed by #2448
Assignees
@yehudit1987 @gjyotin305
Labels
area/testing good first issue Good for newcomers help wanted Extra attention is needed kind/feature

Comments

@Electronic-Waste
Copy link
Member

Electronic-Waste commented Sep 2, 2024 •
edited
Loading

What you would like to be added?

We plan to add e2e tests for notebooks in CI/CD, run with papermill.

REF: https://github.com/nteract/papermill

The notebook examples in need of e2e tests are listed in the following table:

Under examples/v1beta1/kubeflow-pipelines:

  • early-stopping.ipynb
  • kubeflow-e2e-mnist.ipynb

Under examples/v1beta1/sdk:

  • cmaes-and-resume-policies.ipynb
  • nas-with-darts.ipynb
  • tune-train-from-func.ipynb

And I would strongly recommend that we start with examples under sdk subdirectory since examples under kubeflow-pipelines need full kubeflow components on test env and are more difficult :)

Why is this needed?

This will help us ensure the correctness of our notebook examples for data scientists.

Love this feature?

Give it a 👍 We prioritize the features with most 👍
@andreyvelich
Copy link
Member

/area testing
/good-first-issue
/remove-label lifecycle/needs-triage

@google-oss-prow Google OSS Prow
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/area testing
/good-first-issue
/remove-label lifecycle/needs-triage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added area/testing good first issue Good for newcomers help wanted Extra attention is needed and removed lifecycle/needs-triage labels Sep 2, 2024
@yehudit1987
Copy link

I am interested in solving this
/assign

@gjyotin305
Copy link

Hi I am interested in adding this feature, could you tell me which notebooks should I start with ? @Electronic-Waste @andreyvelich

/assign

@Electronic-Waste
Copy link
Member Author

Sorry @gjyotin305, this issue has already been taken by @yehudit1987.

I'm glad to help you if you pick another issue:)

@gjyotin305
Copy link

Sorry @gjyotin305, this issue has already been taken by @yehudit1987.

I'm glad to help you if you pick another issue:)

Ok

@Electronic-Waste Electronic-Waste mentioned this issue Sep 19, 2024
Open
6 tasks
@Electronic-Waste Electronic-Waste mentioned this issue Oct 11, 2024
Open
1 task
@Electronic-Waste
Copy link
Member Author

Hi @yehudit1987, are you still working on this?

@andreyvelich
Copy link
Member

@Electronic-Waste As you can see @saileshd1402 worked on the E2Es for Notebooks as part of this PR: kubeflow/training-operator#2274.
Can we consolidate effort to build consistent solution for Katib and Training Operator ?
Maybe we can start with Training Operator, and after it setup the same workflow for Katib.

@Electronic-Waste
Copy link
Member Author

@andreyvelich I agree with you. I'll look into the CI for Training Operator first.

And also, this is a kind reminder that PR #2437 is blocked by this issue. Looking forward to your earliest contributions @yehudit1987. I'm happy to help you with any questions:)

@yehudit1987 yehudit1987 linked a pull request Oct 27, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yehudit1987 yehudit1987

@gjyotin305 gjyotin305

Labels
area/testing good first issue Good for newcomers help wanted Extra attention is needed kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sdk tests with papermill yehudit1987/katib
4 participants
@andreyvelich @yehudit1987 @Electronic-Waste @gjyotin305