make katib-db configurable

[naseemkullah]

katib/pkg/db/v1alpha2/interface.go

Line 21 in 3cbb565

dbNameTmpl = "root:%s@tcp(katib-db:3306)/katib?timeout=5s"

Please make katib-db:3306 configurable with os.Getenv("MYSQL_HOST") and os.Getenv("MYSQL_PORT")

[gaocegege]

We expected that katib mysql is running in k8s, thus we use katib-db directly. But we should make it configurable. I agree.

[naseemkullah]

Thanks. I am working on a helm chart now, and it is not guaranteed that the name of the service will be katib-db for the helm release. In fact it probably won't be. This would really help!!

[gaocegege]

@naseemkullah Oh I really love helm chart! Do you have a deadline for it? We will release a new version at the end of this month maybe.

[naseemkullah]

Thanks! :) :)
Also want to shoutout @dodizzle who has been helping out.

I think we can have it ready soon (maybe 1 more week?), but we would be nice to get some fixes in on code side, mostly parameterizations for MYSQL configs.

Ideally we can use a single MySQL instance with a db for katib and a db for ml-pipeline.

[gaocegege]

@naseemkullah @dodizzle Thanks for your work!

Are you packaging v1alpha1 or v1alpha2 for katib?

[naseemkullah]

I was confused about that actually. Never used kubeflow, really approaching this from Ops perspective.

https://github.com/kubeflow/katib/tree/master/manifests

Which should be ported?

So far we have the following workloads (please ignore helm generated prefix)

lumbering-pika-katib-core
lumbering-pika-katib-core-rest
lumbering-pika-katib-studyjob-controller
lumbering-pika-katib-suggestion-bayesian-optimization
lumbering-pika-katib-suggestion-grid
lumbering-pika-katib-suggestion-hyperband
lumbering-pika-katib-suggestion-random
lumbering-pika-katib-ui

[gaocegege]

Now we are working on v1alpha2. Thus we recommend doing it after v1alpha2 is released.

If you want to run v1alpha1, you should install all the components in manifests/v1alpha1

[gaocegege]

lumbering-pika-katib-core
lumbering-pika-katib-core-rest
lumbering-pika-katib-studyjob-controller
lumbering-pika-katib-suggestion-bayesian-optimization
lumbering-pika-katib-suggestion-grid
lumbering-pika-katib-suggestion-hyperband
lumbering-pika-katib-suggestion-random
lumbering-pika-katib-ui

Here missed a DB

[naseemkullah]

yes we have deployed with the helm mysql chart, as a dependency: https://github.com/helm/charts/blob/d87d8c7b7f4a374e39f152d3a9334ffc3d80c437/incubator/kubeflow/charts/katib/requirements.yaml
it generated lumbering-pika-mysql service...

Also created a temp service katib-db to bypass lack of configuration:
https://github.com/helm/charts/blob/d87d8c7b7f4a374e39f152d3a9334ffc3d80c437/incubator/kubeflow/charts/katib/templates/temporary-mysql-service.yaml

[gaocegege]

Then I think it should work. If the url is configurable.

[naseemkullah]

bump

[gaocegege]

/assign