Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Ensure that metrics are deleted when experiment is deleted #808

Closed
johnugeorge opened this issue Sep 25, 2019 · 6 comments · Fixed by #830
Closed

[enhancement] Ensure that metrics are deleted when experiment is deleted #808

johnugeorge opened this issue Sep 25, 2019 · 6 comments · Fixed by #830
Assignees
@hougangliu
Labels
priority/p0

Comments

@johnugeorge
Copy link
Member

When experiment is deleted, metrics should be deleted
@gaocegege
Copy link
Member

/priority p0

@gaocegege
Copy link
Member

/assign

@gaocegege
Copy link
Member

We come to an agreement that we should implement the feature in Trial level. I am going to add a finalizer in Trial CRD and an API in manager to implement it.

@gaocegege
Copy link
Member

We dropped the useless APIs in GRPC #818 , then we need to add a new API to let trial controllers delete the metrics when the trial is deleted.

@gaocegege
Copy link
Member

/unassign
/assign

@gaocegege
Copy link
Member

/assign @hougangliu
/unassign @gaocegege

@k8s-ci-robot k8s-ci-robot assigned hougangliu and unassigned gaocegege Sep 28, 2019
@hougangliu hougangliu mentioned this issue Sep 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hougangliu hougangliu

Labels
priority/p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove metrics in DB when delete trial
4 participants
@johnugeorge @gaocegege @hougangliu @k8s-ci-robot