Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add new trials to a succeeded Experiment #891

Closed
gaocegege opened this issue Oct 23, 2019 · 3 comments · Fixed by #952
Closed

[feature] Add new trials to a succeeded Experiment #891

gaocegege opened this issue Oct 23, 2019 · 3 comments · Fixed by #952

Comments

@gaocegege
Copy link
Member

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Now we cannot achieve it because of:

	reconcileRequired := !instance.IsCompleted()
	if reconcileRequired {
		r.ReconcileTrials(instance, trials.Items)
	}

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@johnugeorge
Copy link
Member

Yes. We have to add extra check when we support resuming trials

@gaocegege
Copy link
Member Author

/priority p3

@johnugeorge
Copy link
Member

#952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants