Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mysql based unit tests #243

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Add mysql based unit tests #243

merged 1 commit into from
Nov 20, 2018

Conversation

toshiiw
Copy link
Contributor

@toshiiw toshiiw commented Nov 12, 2018 •
edited
Loading

  • test in the CI environment
  • not sure if proper tear down is needed
  • maybe add more tests for SQL implemented logic

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @toshiiw. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@toshiiw toshiiw changed the title Add mysql based unit tests [WIP] Add mysql based unit tests Nov 12, 2018
@YujiOshima
Copy link
Contributor

/ok-to-test

@toshiiw
Copy link
Contributor Author

toshiiw commented Nov 15, 2018

seems like I need to tweak workflows.libsonnet to run setup-cluster before unit-test.

@toshiiw
Add mysql based unit tests
1f25d46 
Signed-off-by: IWAMOTO Toshihiro <iwamoto@valinux.co.jp>
@toshiiw toshiiw changed the title [WIP] Add mysql based unit tests Add mysql based unit tests Nov 16, 2018
@YujiOshima
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YujiOshima
Copy link
Contributor

/retest

1 similar comment
@toshiiw
Copy link
Contributor Author

toshiiw commented Nov 20, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 206bcaa into kubeflow:master Nov 20, 2018
@toshiiw toshiiw deleted the mysql-db-tests branch November 21, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddysher ddysher Awaiting requested review from ddysher

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

Assignees

@YujiOshima YujiOshima

Labels
approved lgtm ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toshiiw @k8s-ci-robot @YujiOshima