Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show experiment status in json #853

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Oct 3, 2019

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Not sure if we want it. Richard complains that we do not show experiment info in UI, and I am not good at data-visualization. Thus use react-json-view to visualize json directly.

图片

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@hougangliu
Copy link
Member

/lgtm

@gaocegege
Copy link
Member Author

@johnugeorge Does it work for you?

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

This needs a rebase?

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

Rebased, need LGTM

@hougangliu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5cdbde6 into kubeflow:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants