Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

kfctl Makefile needs to be fixed to build with Darwin #161

Closed
jlewi opened this issue Jan 7, 2020 · 0 comments · Fixed by #162
Closed

kfctl Makefile needs to be fixed to build with Darwin #161

jlewi opened this issue Jan 7, 2020 · 0 comments · Fixed by #162
Labels
area/kfctl kind/bug priority/p0

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 7, 2020

It looks like in the move from kubeflow/kubeflow to kubeflow/kfctl some of the fixes to the Makefile to correctly build kfctl for Darwin.

Here are the Make rules to cross compile for Darwin
https://github.com/swiftdiaries/kubeflow/blob/69a9c4ef3582cbbee46831a4395ce540ce5f0ee2/bootstrap/Makefile#L107

We should update the corresponding rules in the kubeflow/kfctl Makefile to match

/cc @richardsliu
/cc @Bobgy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/kfctl kind/bug priority/p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Makefile for Darwin richardsliu/kfctl
1 participant
@jlewi