Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-web-app fails with kustomize build for aws overlay #1182

Closed
apryiomka opened this issue May 19, 2020 · 7 comments · Fixed by #1330
Closed

jupyter-web-app fails with kustomize build for aws overlay #1182

apryiomka opened this issue May 19, 2020 · 7 comments · Fixed by #1330

Comments

@apryiomka
Copy link

Error: accumulating resources: recursed merging from path 'manifest/kustomize/jupyter-web-app/overlays/aws': may not add resource with an already registered id: rbac.authorization.k8s.io_v1_ClusterRoleBinding|~X|jupyter-web-app-cluster-role-binding
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.88
platform/aws 0.51

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@apryiomka
Copy link
Author

It seems like aws overlay is causing this error...

@apryiomka apryiomka changed the title jupyter-web-app fails with kustomize build jupyter-web-app fails with kustomize build for aws overlay May 19, 2020
@PatrickXYS
Copy link
Member

/assign

/cc @Jeffwan

@Jeffwan
Copy link
Member

Jeffwan commented May 19, 2020

@apryiomka

Are you testing master? Can you delete aws overlay at this moment and have another try?

@apryiomka
Copy link
Author

@Jeffwan , i am not testing master, i am trying to get KFServing fix with master. Since it is not tagged to any release, i have no choice but to deploy master. Removing aws overlay does seem to solve the issue. My best guess it is related to this bug in kustomize: kubernetes-sigs/kustomize#1251

@Jeffwan
Copy link
Member

Jeffwan commented May 20, 2020

@Jeffwan , i am not testing master, i am trying to get KFServing fix with master. Since it is not tagged to any release, i have no choice but to deploy master. Removing aws overlay does seem to solve the issue. My best guess it is related to this bug in kustomize: kubernetes-sigs/kustomize#1251

em. master components have been refactored but it's still using base rather than base_v3 in this case. I have not looked into details yet. AWS overlay was added recently that's why I suggest to remove and see it's working or not. If original kfdef doesn't work, then it could be kustomize issue

@PatrickXYS
Copy link
Member

The reason why this fails:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../../base
configMapGenerator:
- name: jupyter-web-app-config
  behavior: replace
  files:
  - spawner_ui_config.yaml

We need to change this into:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
bases:
- ../../base
configMapGenerator:
- name: jupyter-web-app-config
  behavior: replace
  files:
  - spawner_ui_config.yaml

Otherwise, it will re-deploy ../../base resources.

But this change induces another issue, I'll keep updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants