Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused role and rolebinding yaml files #2628

Closed
wants to merge 1 commit into from

Conversation

rahulsurwade08
Copy link

Which issue is resolved by this Pull Request:
Resolves #2601

Description of your changes:
Hey @juliusvonkohout , I check this issue at my end and I found that the Service Account: jupyter-notebook doesn't exists and the role.yaml and role-binding.yaml are pointing to it. cluster-role.yaml and cluster-role-binding.yaml have been pointing to Service Account: service-account and cluster-role.yaml has same rules present in role.yaml. Adding a screenshot for reference.

Checklist:

kubeflow-issue-ss
[ ] Unit tests pass:
Make sure you have installed kustomize == 5.0.3
1. make generate-changed-only
2. make test

Copy link

google-cla bot commented Feb 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rahulsurwade08
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jupyter-web-app defines RoleBinding for non-existing ServiceAccount jupyter-notebook
1 participant