KFP 2.4.0 follow up (metacontroller)

[juliusvonkohout]

Validation Checklist

• Is this a Kubeflow issue?
• Are you posting in the right repository ?
• Did you follow the Kubeflow installation guideline ?
• Is the issue report properly structured and detailed with version numbers?
• Is this for Kubeflow development ?
• Would you like to work on this issue?
• You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Version

master

Describe your issue

@biswassri please wait for my metacontroller fixes in #2953 to be merged and then pull from master. Afterwards with the improved tests you can try to update metacontroller from 2.6.1 to 4.x. Depending on what works we merge it in kubeflow/manifests and in any case we need to upstream to kubeflow/pipelines as well.

And please also remove the PSS patches "(no change)" that we have upstreamed from Kubeflow/manifests

Patching file: contrib/security/PSS/patches/cache-server.yaml
deployment.apps/cache-server patched (no change)
Patching file: contrib/security/PSS/patches/cluster-jwks-proxy.yaml
deployment.apps/cluster-jwks-proxy patched
Patching file: contrib/security/PSS/patches/kfam.yaml
deployment.apps/profiles-deployment patched
Patching file: contrib/security/PSS/patches/kubeflow-pipelines-profile-controller.yaml
deployment.apps/kubeflow-pipelines-profile-controller patched
Patching file: contrib/security/PSS/patches/manager.yaml
deployment.apps/profiles-deployment patched
Patching file: contrib/security/PSS/patches/metacontroller.yaml
statefulset.apps/metacontroller patched (no change)
Patching file: contrib/security/PSS/patches/metadata-envoy-deployment.yaml
deployment.apps/metadata-envoy-deployment patched (no change)
Patching file: contrib/security/PSS/patches/metadata-grpc-deployment.yaml
deployment.apps/metadata-grpc-deployment patched (no change)
Patching file: contrib/security/PSS/patches/metadata-writer.yaml
deployment.apps/metadata-writer patched (no change)
Patching file: contrib/security/PSS/patches/minio.yaml
deployment.apps/minio patched (no change)
Patching file: contrib/security/PSS/patches/ml-pipeline-persistenceagent.yaml
deployment.apps/ml-pipeline-persistenceagent patched (no change)
Patching file: contrib/security/PSS/patches/ml-pipeline-scheduledworkflow.yaml
deployment.apps/ml-pipeline-scheduledworkflow patched (no change)
Patching file: contrib/security/PSS/patches/ml-pipeline-ui.yaml
deployment.apps/ml-pipeline-ui patched (no change)
Patching file: contrib/security/PSS/patches/ml-pipeline-viewer-crd.yaml
deployment.apps/ml-pipeline-viewer-crd patched (no change)
Patching file: contrib/security/PSS/patches/ml-pipeline-visualizationserver.yaml
deployment.apps/ml-pipeline-visualizationserver patched (no change)
Patching file: contrib/security/PSS/patches/ml-pipeline.yaml
deployment.apps/ml-pipeline patched (no change)
Patching file: contrib/security/PSS/patches/mysql.yaml
deployment.apps/mysql patched (no change)
Patching file: contrib/security/PSS/patches/workflow-controller.yaml
deployment.apps/workflow-controller patched (no change)

Steps to reproduce the issue

Install Kubeflow

Put here any screenshots or videos (optional)

No response

[juliusvonkohout]

CC @hbelmiro @tarekabouzeid because right now upstream KFP multi-user is broken until we fix the metacontroller there as well.

[varodrig]

CC @hbelmiro @tarekabouzeid because right now upstream KFP multi-user is broken until we fix the metacontroller there as well.

@juliusvonkohout when this fix will be implemented?

[juliusvonkohout]

CC @hbelmiro @tarekabouzeid because right now upstream KFP multi-user is broken until we fix the metacontroller there as well.

@juliusvonkohout when this fix will be implemented?

@tarekabouzeid @biswassri want to work on it

[juliusvonkohout]

@tarekabouzeid @biswassri I did not get feedback for a week, so I created kubeflow/pipelines#11608 to at least fix the broken upstream KFP. Afterwards you can still upgrade metacontroller from 2.6.1 to 4.x

[biswassri]

@juliusvonkohout @tarekabouzeid Apologies, I hadn't checked email/git over the last week. So I missed this until now. I created the clean-up of the PSS patches PR #2986 since it's not dependent on the KFP sync PR.

Once kubeflow/pipelines#11608 is merged in, I can check with the metacontroller upgrade. Hope that's okay.

[tarekabouzeid]

@juliusvonkohout apologies for that also. I was occupied last week.
@biswassri I can join the metacontroller upgrade as well.