Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend] tslint should ignore generated code #2404

Closed
Bobgy opened this issue Oct 16, 2019 · 1 comment · Fixed by #2431
Closed

[Frontend] tslint should ignore generated code #2404

Bobgy opened this issue Oct 16, 2019 · 1 comment · Fixed by #2431
Assignees
@Bobgy
Labels
area/frontend priority/p0

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Oct 16, 2019

@jingzhang36 reported that tslint reports an error on generated code. The code is correct, just not as clean as what we should write.

I think we should just let tslint skip generated code, it doesn't add much value to us.

/priority p0
/area front-end
#frontend-pH
@Bobgy Bobgy changed the title [Frontend] tslint should ignore generated code [Frontend] tslint should ignore test and generated code Oct 16, 2019
@Bobgy Bobgy changed the title [Frontend] tslint should ignore test and generated code [Frontend] tslint should ignore generated code Oct 16, 2019
This was referenced Oct 16, 2019
Closed
Merged
@Bobgy
Copy link
Contributor Author

Bobgy commented Oct 20, 2019

/assign @Bobgy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bobgy Bobgy

Labels
area/frontend priority/p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Frontend] Configure tslint for better DX Bobgy/pipelines
2 participants
@Bobgy @k8s-ci-robot