Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Support artifact custom types in V2 compatible mode #5798

Closed
zijianjoy opened this issue Jun 4, 2021 · 5 comments
Closed

[sdk] Support artifact custom types in V2 compatible mode #5798

zijianjoy opened this issue Jun 4, 2021 · 5 comments
Assignees
Labels
area/sdk kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@zijianjoy
Copy link
Collaborator

zijianjoy commented Jun 4, 2021

Reference: #5668
Blocks: #3970

In KFP v1, we log output artifact types to MLMD as annotated in DSL. KFP UI can use it to visualize HTML, Markdown, etc as planned in #3970. However, in KFP v2 compatible mode, such artifact type is system.Artifact. We are not able to retrieve type name from component definition in UI.

In order to support visualization compatibility in V2 compatible mode, we need to support custom artifact types from SDK. Once UI can retrieve artifact type from MLMD, we can visualize HTML/Markdown according to the artifact type.

cc @Bobgy @Ark-kun


Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@Bobgy
Copy link
Contributor

Bobgy commented Jun 4, 2021

Thank you @zijianjoy! for starting the issue

slightly adjusting some wordings

@Bobgy
Copy link
Contributor

Bobgy commented Jun 4, 2021

Several options for open discussion:

@Ark-kun
Copy link
Contributor

Ark-kun commented Jun 11, 2021

Use duck typing to determine type, e.g. if metadata.type == 'HTML', we treat it as HTML artifact.

Perhaps we can start with this.

We'll need the ability to preserve the original types names for all custom artifact types, so adding system types might not be feasible or scalable.

@stale
Copy link

stale bot commented Oct 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Oct 2, 2021
@zijianjoy
Copy link
Collaborator Author

We have determined to use HTML and Markdown types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
None yet
Development

No branches or pull requests

4 participants