Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Inaccurate two-level dropdown selection #8133

Closed
zpChris opened this issue Aug 10, 2022 · 2 comments
Closed

[frontend] Inaccurate two-level dropdown selection #8133

zpChris opened this issue Aug 10, 2022 · 2 comments
Assignees
Labels
area/frontend kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label.

Comments

@zpChris
Copy link
Contributor

zpChris commented Aug 10, 2022

Environment

  • How did you deploy Kubeflow Pipelines (KFP)?

Kubeflow Pipelines Standalone

  • KFP version:

2.0.0-alpha.3

Steps to reproduce

  1. Create a run which has two Confusion Matrix artifacts of the same type on the same execution
  • One artifact has the name Artifact ID #<id>, and the other artifact has no name but an ID of <id>
  • These confusion matrices should be different
  • Note: This may be difficult to accomplish, and is not presented here, but the issue is shown by understanding the underlying code and implementation.
  1. Go to the "Runs" tab on KFP
  2. Select that run and one other, and click "Compare Runs"
  3. Select the "Confusion Matrix" tab under "Metrics"
  4. Select both confusion matrices and view the compare results

Expected result

The Confusion Matrices should be displayed as expected, but instead one of the confusion matrices will be shown twice.

Materials and Reference

On the two-panel layout for Confusion Matrices, HTML, and Markdown, we need to improve the differentiation between display name and ID, likely by adding an underlying value to each dropdown item (rather than requiring each name be unique).

This is mentioned in this GitHub discussion; essentially, if an Execution has a displayName of exact value “Execution ID #1” and another Execution has no displayName but has an ID of 1, we run into mis-identified artifacts and dropdown items due to the logic implemented at getLinkedArtifactFromSelectedItem.


Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Copy link

github-actions bot commented Mar 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Mar 4, 2024
Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend kind/bug lifecycle/stale The issue / pull request is stale, any activities remove this label.
Projects
None yet
Development

No branches or pull requests

2 participants