-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkout.sh shouldn't require PROW environment variables #42
Comments
@jlewi can you provide more info about which vars are prow env vars (is that listed somwhere?) and what the more convenient syntax is? It's not clear what needs to be replaced. |
@scottilee I might be wrong but I think this is the list: https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables |
We have But I think we might want to standardize on I think we can close this issue. |
checkout.sh supports the PROW environment variables.
But it also supports the more convenient syntax we introduced to specify for extra repos.
For workflows triggered outside of prow (e.g. manually) its more convenient just to specify EXTRA_REPOS.
We should update checkout.sh so that it doesn't assume REPO_OWNER and other prow environment variables.
The text was updated successfully, but these errors were encountered: