Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout.sh shouldn't require PROW environment variables #42

Closed
jlewi opened this issue Feb 25, 2018 · 4 comments
Closed

checkout.sh shouldn't require PROW environment variables #42

jlewi opened this issue Feb 25, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 25, 2018

checkout.sh supports the PROW environment variables.

But it also supports the more convenient syntax we introduced to specify for extra repos.

For workflows triggered outside of prow (e.g. manually) its more convenient just to specify EXTRA_REPOS.

We should update checkout.sh so that it doesn't assume REPO_OWNER and other prow environment variables.

@jlewi jlewi added the good first issue Good for newcomers label Mar 20, 2018
@scottilee
Copy link
Contributor

@jlewi can you provide more info about which vars are prow env vars (is that listed somwhere?) and what the more convenient syntax is? It's not clear what needs to be replaced.

@derekhh
Copy link
Contributor

derekhh commented Jul 24, 2019

@scottilee
Copy link
Contributor

@derekhh Thanks!

@jlewi what is the more convenient syntax you referred to other than EXTRA_REPOS? Is there a list somewhere?

@jlewi
Copy link
Contributor Author

jlewi commented Jul 26, 2019

We have
https://github.com/kubeflow/testing/blob/master/images/checkout_repos.sh

But I think we might want to standardize on
https://github.com/hashicorp/go-getter

I think we can close this issue.

@jlewi jlewi closed this as completed Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants