-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise labels for issues and PRs #326
Comments
SGTM. Anyone else have input? |
tools used in kube: |
I think caicloud/kubeflow-controller has 29 labels and some labels are handled by caicloud-bot, e.g. Labels are helpful for contributors or users. And I recommend importing a bot to the repo to add labels based on some rules automatically. For example https://github.com/icecrime/poule, which is used by moby/moby and alibaba/pouch. |
@gaocegege Gotcha. Please go ahead. |
Can we reuse K8s bots like label_sync? |
Should we have labels for issues specific to a particular distribution/cloud e.g. distro/gke What does K8s do? |
@jlewi There are many SIGs in kubernetes community for different domain or distribution, such as I took a look at the labels of kubernetes/kubernetes repo which have been divided into many classes as below. Ref: https://github.com/kubernetes/kubernetes/labels?page=1&sort=name-asc
Cause Kubernetes is a bigger and more mature community, we can pick up some of them, such as Maybe @ScorpioCPH @ddysher could give more info of kubernetes community. |
Many labels are used for +1 pick up some of them, |
So looks like gke would be under team. |
I think it is better to put gke in distro since it is an environment, and google could be placed in team 🤔 WDYT @DjangoPeng I think the issues are not friendly to new contributors or users now, could you give me a write access temporarily and I could add these labels manually to the existing issues? @jlewi |
@gaocegege invite with write access sent. Thank you. |
Does someone want to capture the relevant labels in this issue in a PR documenting them in kubeflow/community? |
Hi @gaocegege @texasmichelle and I put this list together in this duplicate issue without being aware of your work here. Would you mind taking a look? |
@chrisheecho I added some comments to the docs, and I will close the issue since it is dup Thank you |
dup with kubeflow/community#12 |
We'd better standardise labels for our repo, which is good for issue management. For example, we have 14 labels in caicloud/kubeflow-controller repo as below:
WDYT @jlewi
The text was updated successfully, but these errors were encountered: