Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise labels for issues and PRs #326

Closed
DjangoPeng opened this issue Jan 18, 2018 · 15 comments
Closed

Standardise labels for issues and PRs #326

DjangoPeng opened this issue Jan 18, 2018 · 15 comments

Comments

@DjangoPeng
Copy link
Member

We'd better standardise labels for our repo, which is good for issue management. For example, we have 14 labels in caicloud/kubeflow-controller repo as below:

image

WDYT @jlewi

@jlewi
Copy link
Contributor

jlewi commented Jan 19, 2018

SGTM. Anyone else have input?

@ddysher
Copy link
Member

ddysher commented Jan 19, 2018

@gaocegege
Copy link
Member

gaocegege commented Jan 19, 2018

@DjangoPeng

we have 14 labels in caicloud/kubeflow-controller repo as below:

I think caicloud/kubeflow-controller has 29 labels and some labels are handled by caicloud-bot, e.g. size/xx for PR. caicloud/kubeflow-clientset has 14 labels, maybe there is a typo 😄

@jlewi

Labels are helpful for contributors or users. And I recommend importing a bot to the repo to add labels based on some rules automatically. For example https://github.com/icecrime/poule, which is used by moby/moby and alibaba/pouch.

@DjangoPeng
Copy link
Member Author

@gaocegege Gotcha. Please go ahead.

@jlewi
Copy link
Contributor

jlewi commented Jan 19, 2018

Can we reuse K8s bots like label_sync?

@jlewi
Copy link
Contributor

jlewi commented Jan 20, 2018

Should we have labels for issues specific to a particular distribution/cloud e.g.

distro/gke
distro/minikube
distro/canonical

What does K8s do?

@DjangoPeng
Copy link
Member Author

DjangoPeng commented Jan 21, 2018

@jlewi There are many SIGs in kubernetes community for different domain or distribution, such as

image

I took a look at the labels of kubernetes/kubernetes repo which have been divided into many classes as below. Ref: https://github.com/kubernetes/kubernetes/labels?page=1&sort=name-asc

  • area/{api, admin, custom-resources, ...}
  • kind/{api-change, bug, cleanup, ...}
  • lifecycle/{frozen, rotten, ...}
  • milestone/{incomplete-labels, need-approval, ...}
  • priority/{P0, P1, ..., failing-test, ...}
  • queue/{blocks-others, fix, ...}
  • sig/{api-machinery, apps, ...}
  • size/{XS, XL, ...}
  • status/{in-progress, in-review, ...}
  • team/{gke, huawei, ...}
  • ...

Cause Kubernetes is a bigger and more mature community, we can pick up some of them, such as area/..., kind/..., priority/..., size/..., and status/....

Maybe @ScorpioCPH @ddysher could give more info of kubernetes community.

@ScorpioCPH
Copy link
Member

Many labels are used for bot (e.g. lifecycle, priority, size, status) in kubernetes.

+1 pick up some of them, area, kind, priority.

@jlewi
Copy link
Contributor

jlewi commented Jan 23, 2018

So looks like gke would be under team.

@gaocegege
Copy link
Member

I think it is better to put gke in distro since it is an environment, and google could be placed in team 🤔

WDYT @DjangoPeng

I think the issues are not friendly to new contributors or users now, could you give me a write access temporarily and I could add these labels manually to the existing issues? @jlewi

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

@gaocegege invite with write access sent. Thank you.

@jlewi
Copy link
Contributor

jlewi commented Feb 16, 2018

Does someone want to capture the relevant labels in this issue in a PR documenting them in kubeflow/community?

@chrisheecho
Copy link

Hi @gaocegege @texasmichelle and I put this list together in this duplicate issue without being aware of your work here. Would you mind taking a look?

@gaocegege
Copy link
Member

gaocegege commented Mar 1, 2018

@chrisheecho I added some comments to the docs, and I will close the issue since it is dup

Thank you

@gaocegege
Copy link
Member

dup with kubeflow/community#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants