-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] Rename the cmd/tf_operator to cmd/tf-operator #363
Comments
Hi @gaocegege I would like to work on this issue. Could you please elaborate a little bit since I am just a beginner here. |
Hi @AK-ayush Thank you and I think you just update the package name. But I think we need to make sure that the changes will not break kubeflow. So maybe you need to file a PR to kubeflow, too. BTW, you could get involved into our community: https://github.com/kubeflow/kubeflow#get-involved. We have an active slack channel :) |
@jlewi Could we update the package name now? Or we could wait until we release a version. |
This should be fine. Kubeflow's ksonnet registry uses a specific Docker image so when we update the Docker image we can catch and fix any breakages. |
@AK-ayush Then feel free to just update the package name in this repo, and you can file a WIP PR ASAP, the CI test will help you debug 😄 |
@gaocegege I've submitted initial PR #393 Please, have a look at it and let me know. Thanks |
Close as #393. |
The new name is more k8s style, and #350 also sets the repo name to tf-operator.
And, the command name in kubeflow should be changed, too.
The text was updated successfully, but these errors were encountered: