-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] copy labels and anotations to pod from tfjob #543
Comments
Are you suggesting that annotations in the TFJob metadata be copied to the pod metadata? Or are you suggesting that metadata inside the TFJob PodTemplateSpec's be copied to the actual pods created. If the latter then I agree with you. This is necessary to support various extensions/features that rely on annotations (e.g. admission controllers, TPUs). Bumping to P1 because I'd like this to be fixed in our 0.2 release so that TPUs are well supported. |
Ref #542 The latter, I think. |
We already implemented it in v1alpha2, my mistake. |
I set the priority to p2 sine we implemented it and the last work is to add test cases. |
Close by #658 |
The text was updated successfully, but these errors were encountered: