Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] copy labels and anotations to pod from tfjob #543

Closed
1 of 2 tasks
gaocegege opened this issue Apr 17, 2018 · 5 comments
Closed
1 of 2 tasks

[test] copy labels and anotations to pod from tfjob #543

gaocegege opened this issue Apr 17, 2018 · 5 comments

Comments

@gaocegege
Copy link
Member

gaocegege commented Apr 17, 2018

  • Implement it in v1alpha2
  • Add test for v1alpha1
@jlewi
Copy link
Contributor

jlewi commented May 8, 2018

Are you suggesting that annotations in the TFJob metadata be copied to the pod metadata? Or are you suggesting that metadata inside the TFJob PodTemplateSpec's be copied to the actual pods created.

If the latter then I agree with you. This is necessary to support various extensions/features that rely on annotations (e.g. admission controllers, TPUs).

Bumping to P1 because I'd like this to be fixed in our 0.2 release so that TPUs are well supported.

@gaocegege
Copy link
Member Author

Ref #542

The latter, I think.

@gaocegege
Copy link
Member Author

We already implemented it in v1alpha2, my mistake.

@gaocegege
Copy link
Member Author

I set the priority to p2 sine we implemented it and the last work is to add test cases.

@gaocegege gaocegege changed the title copy labels and anotations to pod from tfjob [test] copy labels and anotations to pod from tfjob Jun 14, 2018
@gaocegege gaocegege self-assigned this Jun 14, 2018
@gaocegege
Copy link
Member Author

Close by #658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants