Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Use dep instead of glide to reduce the size of vendor #556

Closed
gaocegege opened this issue Apr 24, 2018 · 6 comments
Closed

[go] Use dep instead of glide to reduce the size of vendor #556

gaocegege opened this issue Apr 24, 2018 · 6 comments

Comments

@gaocegege
Copy link
Member

Please see #541 (comment)

We met the same problem during the development of v1alpha2. And we choose to copy the code from k8s into our code base.

I think maybe we should migrate from glide to dep and use dep prune to remove useless packages.

@jlewi
Copy link
Contributor

jlewi commented Apr 24, 2018

I don't have an opinion about glide vs. dep but lets try to get agreement and be consistent across Kubeflow projects.

Can you send an email to the mailing list asking folks to chime in on this issue?

Is Kubernetes using one of these options?

@gaocegege
Copy link
Member Author

gaocegege commented Apr 24, 2018

I think the vendor tool is not the gap since glide and dep are all easy to use. We do not need any additional work on it. Thus I think dep and glide all works for me.

I migrate from glide to dep because we are using some code in k8s.io/kubernetes and k8s code base is too large. We do not expect to put k8s code in our vendor. Now we just copy the code that we used manually into our code, but it is not the right way, I think.

Kubernetes uses godeps because of historical reasons, I think.

@gaocegege
Copy link
Member Author

gaocegege commented Apr 24, 2018

Maybe we could use @kubeflow to ask all members for their opinions.

It does not work. I will send an email for this issue 😃

@jlewi
Copy link
Contributor

jlewi commented Apr 25, 2018

You're reasoning seems sound to me. It would be good to get buy in from the primary folks working on go-related projects as part of Kubeflow.

/cc @YujiOshima for katib
/cc @wbuchwalter For TFJobs UI
/cc @balajismaniam

@gaocegege
Copy link
Member Author

Katib is using dep from the beginning 😊ཽ

@balajismaniam
Copy link

balajismaniam commented Apr 25, 2018

There is on-going work to migrate kubernetes/kubernetes to dep as well: kubernetes/kubernetes#57795. I think it is a good idea to standardize dep management across all kubeflow org projects.

PS: KVC uses dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants