Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFJob operator should pass through annotations to the pod #573

Closed
jlewi opened this issue May 8, 2018 · 2 comments
Closed

TFJob operator should pass through annotations to the pod #573

jlewi opened this issue May 8, 2018 · 2 comments
Labels
api/v1alpha2 priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented May 8, 2018

If a user sets annotations in the PodTemplateSpec inside TFJob, these annotations should get set on the actual pods created.

This important for custom hardware (e.g. TPUs) since custom hardware support might depend on pod annotations.

Marking this P1 because we want it to be fixed as part of our 0.2 release so that TPUs are well supported.
@jlewi
Copy link
Contributor Author

jlewi commented May 8, 2018

Its possible this is already fixed in v1alpha2. We should check and an appropriate E2E test.

@jlewi
Copy link
Contributor Author

jlewi commented May 8, 2018

Duplicate of #543

@jlewi jlewi marked this as a duplicate of #543 May 8, 2018
@jlewi jlewi closed this as completed May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api/v1alpha2 priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi