Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup release process for CRD #63

Closed
jlewi opened this issue Oct 19, 2017 · 2 comments
Closed

Setup release process for CRD #63

jlewi opened this issue Oct 19, 2017 · 2 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Oct 19, 2017

We should setup a release process for the CRD.

The artifact should be a helm package published in GCS so that customers can just do

helm install http://storage.googleapis.com/mlkube-io-charts/tfjob/latest.tgz

or for users wanting a specific version

helm install http://storage.googleapis.com/mlkube-io-charts/tfjob/chart-v20171019-383eafd.tgz

The steps involved are

  1. Get the latest green postsubmit
  2. Check out the code
  3. Build and push the docker image
  4. Update default values for the chart to point to the new image.
  5. Push a .tar to GCS

We can have our Postsubmit ProwJobs write a GCS file containing the latest green summit.

I think its better to rebuild the docker image rather than promote images in gcr.io/mlkube-testing because permissions on the images in gcr.io/mlkube-testing are rather broad (they could be modified by any code running under K8s prow presubmits).

We could eventually setup GCB or some other mechanism to trigger pushes automatically but that's not a priority.
@jlewi jlewi mentioned this issue Oct 30, 2017
Merged
@jlewi jlewi closed this as completed in #98 Oct 30, 2017
@jlewi jlewi reopened this Oct 30, 2017
@jlewi
Copy link
Contributor Author

jlewi commented Oct 30, 2017

release.py is failing.

@jlewi jlewi mentioned this issue Oct 30, 2017
Merged
jlewi added a commit that referenced this issue Oct 30, 2017
@jlewi
Fix bugs in the release script. (#100)
bc0c348 
Need to set GOPATH properly before building the code.

Copy the release scripts to the Docker image rather than cloning the
repo. This makes it easier to push changes to the releaser because
we can just build the image with local changes. Otherwise we need to
commit the changes first and then build the Docker image.

Need to break out of the loop if only building once

Need to install helm in the releaser image because we use it to build the helm package.

Need to build the docker images using GCB so we don't need to access docker inside the pod running the releaser.

Store the image version in a json file inside the container and print out.

Related to #63
@jlewi
Copy link
Contributor Author

jlewi commented Oct 30, 2017

Continuous releasing is working.
The release:
gs://tf-on-k8s-dogfood-releases/v20171030-bc0c348/
was automatically picked up and created.

@jlewi jlewi closed this as completed Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi