Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management #7

Closed
wbuchwalter opened this issue Jul 27, 2017 · 3 comments
Closed

Dependency management #7

wbuchwalter opened this issue Jul 27, 2017 · 3 comments

Comments

@wbuchwalter
Copy link
Contributor

Hi,
Currently the project is not buildable because there has been breaking changes in k8s.io/client-go/pkg/api/v1, so go install complains that it cannot find buildable Go source files.

Are you open to add something like dep or Glide to lock-in specific versions of the project's dependencies?

@jlewi
Copy link
Contributor

jlewi commented Jul 30, 2017

Hi,

Yes. I'm open to this.

Would bazel be an option?

@vishh @foxish Do you have thoughts about what the best way to solve this is?

I'm not particularly familiar with Glide or dep. I'd like to adopt whatever tooling K8s is planning on using.

@wbuchwalter
Copy link
Contributor Author

wbuchwalter commented Jul 30, 2017

I believe bazel doesn't offer dependency management but only the build system.

Most kubernetes projects are using godep, but it seems this tool is now being slowly replaced by glide or dep. See kubernetes/client-go own doc which talk about this.

etcd-operator is using glide for example.

It should be quite easy to move from one to the other if necessary though.

@wbuchwalter
Copy link
Contributor Author

Fixed by #8

franciscojavierarceo pushed a commit to franciscojavierarceo/training-operator that referenced this issue Apr 12, 2024
Signed-off-by: ted chang <htchang@us.ibm.com>
KPostOffice pushed a commit to KPostOffice/training-operator that referenced this issue May 23, 2024
Signed-off-by: ted chang <htchang@us.ibm.com>
ChenYi015 pushed a commit to ChenYi015/training-operator that referenced this issue Sep 20, 2024
Disable TF_CONFIG when job standalone
Fiona-Waters pushed a commit to Fiona-Waters/training-operator that referenced this issue Oct 1, 2024
Signed-off-by: ted chang <htchang@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants