Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/Clarify Accelerators config #71

Closed
wbuchwalter opened this issue Oct 21, 2017 · 1 comment
Closed

Simplify/Clarify Accelerators config #71

wbuchwalter opened this issue Oct 21, 2017 · 1 comment
Assignees

Comments

@wbuchwalter
Copy link
Contributor

Accelerators configuration should be surfaced in chart's values.yaml, and examples should be provided for the different providers.

@jlewi
Copy link
Contributor

jlewi commented Oct 21, 2017

In addition to letting users specify config directly, could we have an enum based on which we would select a default config suitable for a particular cloud so a user could do something like

helm install tf-job-operator-chart -n tf-job --wait --replace --set cloud=gke

or

helm install tf-job-operator-chart -n tf-job --wait --replace --set cloud=azure

The cloud value would be used to select from different config files provided as part of the chart.

For users would complete control they could do something like the following

helm install tf-job-operator-chart -n tf-job --wait --replace --set config-file=path/to/config.yaml

@wbuchwalter wbuchwalter self-assigned this Oct 25, 2017
wbuchwalter added a commit that referenced this issue Oct 25, 2017
jlewi pushed a commit that referenced this issue Oct 26, 2017
* #71 simplify accelerators config

* Add a cloud value that accepts gke or azure and will create the corresponding ConfigMap

* Users can create the config manually and not specify a cloud option in order to have complete control of the config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants