Event reporting pod exited with non-zero exit code is improperly formatted

[jlewi]

I recently added an Event to report pods exiting with non-zero exit code.

Here's how the event shows up

Events:
  Type    Reason                          Age   From         Message
  ----    ------                          ----  ----         -------
  Normal  SuccessfulCreatePod             14m   tf-operator  Created pod: t2t-code-search-exporter-worker-0
  Normal  SuccessfulCreateService         14m   tf-operator  Created service: t2t-code-search-exporter-worker-0
  Normal  Pod: %v.%v exited with code %v  14m   tf-operator  kubeflow%!(EXTRA string=t2t-code-search-exporter-worker-0, int32=1)

The code is here
https://github.com/kubeflow/tf-operator/blob/master/pkg/controller.v2/tensorflow/pod.go#L85

The format string looks correct; there are 3 parameters in the format string and 3 arguments.

I'm using an image built from master
gcr.io/kubeflow-images-public/tf_operator:v20180901-454c5c1a

@gaocegege any chance you see what the issue is the event?

If not I guess we could just use fmt.Sprintf

[johnugeorge]

Reason argument in Eventf missing?

[johnugeorge]

3 rd argument is the reason. And from 4, it is the message.

[gaocegege]

Just as @johnugeorge said, https://github.com/kubeflow/tf-operator/blob/master/vendor/k8s.io/client-go/tools/record/event.go#L71:2

[gaocegege]

I will fix it today.