Change group to tensorflow.org and version to v1alpha1. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We have abandoned the name mlkube.io and moved the code into tensorflow so it makes sense to use tensorflow.org as the group. * We downgrade the API version from v1beta1 to v1alpha1. We want to follow the guidelines used by K8s for alpha, beta, stable: https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md#alpha-beta-and-stable-versions according to this definition we our closer to alpha since the API hasn't achieved stability.
Merged
|
@wbuchwalter any comments before I submit? |
|
Looks good to me. |
wbuchwalter
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have abandoned the name mlkube.io and moved the code into tensorflow
so it makes sense to use tensorflow.org as the group.
We downgrade the API version from v1beta1 to v1alpha1.
We want to follow the guidelines used by K8s for alpha, beta, stable:
https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md#alpha-beta-and-stable-versions
according to this definition we our closer to alpha since the API hasn't
achieved stability.