Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename jlewi/mlkube.io in glide.yaml #153

Merged
merged 1 commit into from
Nov 16, 2017
Merged

rename jlewi/mlkube.io in glide.yaml #153

merged 1 commit into from
Nov 16, 2017

Conversation

moon03432
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link

Hi @huangyue18. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi
Copy link
Contributor

jlewi commented Nov 16, 2017

/ok-to-test

@jimexist
Copy link
Member

jimexist commented Nov 16, 2017

also after the name change I guess this shall be updated?

also I was confused about the naming of GIT_TRAINING.

@jlewi jlewi merged commit c4ef91f into kubeflow:master Nov 16, 2017
@jlewi
Copy link
Contributor

jlewi commented Nov 16, 2017

also after the name change I guess this shall be updated?
What in particular are you reffering to

also I was confused about the naming of GIT_TRAINING.
The environment variable GIT_TRAINING is poorly named. Can you suggest a better one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants