let tfJob image configurable #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion. pkg/trainer/training.go, line 283 at r1 (raw file):
Could we add a unittest for this? Comments from Reviewable |
zjj2wry
force-pushed
the
tfImage_configurable
branch
from
2e411ed
to
64c1195
Compare
zjj2wry
commented
Dec 18, 2017
| t.Errorf("Want\n%v; Got\n %v", util.Pformat(c.expected), util.Pformat(c.in)) | ||
| } | ||
| for i, c := range testCases { | ||
| t.Run(fmt.Sprintf("%d", i), func(t *testing.T) { |
There was a problem hiding this comment.
i add this line can help quick find error in table test
--- PASS: TestSetDefaults (0.00s)
--- PASS: TestSetDefaults/0 (0.00s)
--- PASS: TestSetDefaults/1 (0.00s)
--- PASS: TestSetDefaults/2 (0.00s)
|
@jlewi done, ptal |
|
Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Comments from Reviewable |
|
@zjj2wry Looks like there are some conflicts now. |
zjj2wry
force-pushed
the
tfImage_configurable
branch
from
64c1195
to
e1fbfb3
Compare
|
@jlewi rebased, ptal |
jlewi
approved these changes
Dec 20, 2017
|
Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is
Fixes #207
/cc @cwbeitel @jlewi