-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Implement the List interface for TfJobList #278
Conversation
Hi @gaocegege. Thanks for your PR. I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* The kind should be lower case; this error was surfaced while trying to implement the list interface #278 Signed-off-by: Ce Gao <ce.gao@outlook.com>
#276 was merged. Then I will reset the commits and re-push the changes tomorrow(I am in Shanghai and it is 23:00 now) to be more human-readable. |
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
I reassembled the commit, and PTAL 😄 |
/ok-to-test |
/test all |
Notice: The PR is blocked by #276 , I will rebase after it is merged and remove
DO NOT MERGE
The error is caused by the field name in TfJobList:
The name of field
Metadata
should be anonymous field.This change is