Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The flag should be --controller-config-file. #295

Merged
merged 7 commits into from
Jan 11, 2018
Merged

The flag should be --controller-config-file. #295

merged 7 commits into from
Jan 11, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jan 11, 2018 •
edited
Loading

This looks like a regression introduced by all the refactoring.

Fix #279

This change is Reviewable

@jlewi
Fix the junit XML file format.
e348a86 
* Test failures weren't being properly reported to gubernator because we had
  the wrong XML format. We need to use a nested failure tag and specify the
  message inside the tag.
@jlewi
Turn a failed test into a non-zero exit status.
126117c
@jlewi
Fix lint.
6d09603
@jlewi
Start adding a step to report all errors.
845c2b6
@jlewi
The flag should be --controller-config-file.
c2ec56f 
* This looks like a regression introduced by all the refactoring.
@jlewi
Merge remote-tracking branch 'upstream/master' into fix_flag
95cfa46
@jlewi
Revert to head.
37ad402
@coveralls
Copy link

coveralls commented Jan 11, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 30.729% when pulling 37ad402 on jlewi:fix_flag into 833a25a on tensorflow:master.

@coveralls
Copy link

coveralls commented Jan 11, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 30.624% when pulling 37ad402 on jlewi:fix_flag into 833a25a on tensorflow:master.

@coveralls
Copy link

coveralls commented Jan 11, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 30.624% when pulling 37ad402 on jlewi:fix_flag into 833a25a on tensorflow:master.

@jlewi jlewi merged commit e619ac4 into kubeflow:master Jan 11, 2018
@jlewi jlewi mentioned this pull request Jan 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlewi @coveralls