Add service account name to dashboard if RBAC. #298

ConnorDoyle · 2018-01-12T00:48:56Z

This change is

googlebot · 2018-01-12T00:48:59Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

coveralls · 2018-01-12T00:58:27Z

Coverage increased (+0.1%) to 30.729% when pulling fd6ad00 on ConnorDoyle:dashboard-serviceaccount into e619ac4 on tensorflow:master.

ScorpioCPH · 2018-01-12T12:29:23Z

tf-job-operator-chart/templates/dashboard.yaml

@@ -21,11 +21,14 @@ spec:
      labels:
        name: tf-job-dashboard
    spec:    
+{{- if .Values.rbac.install }}
+      serviceAccountName: tf-job-operator


s/tf-job-operator/tf-job-dashboard ?

👍 I will edit the chart to also create this separate service account for the dashboard and associated RBAC.

* Some lint checks have crept in due to kubeflow#274 * Fix kubeflow#298 (py lint issues) * Need to exclude some of the dependencies used by the frontend.

ConnorDoyle · 2018-01-12T22:43:49Z

Working on the corporate CLA; hopefully approved soon.

googlebot · 2018-01-12T22:44:00Z

CLAs look good, thanks!

ConnorDoyle · 2018-01-13T06:10:25Z

@ScorpioCPH updated

coveralls · 2018-01-13T06:19:13Z

Coverage remained the same at 31.609% when pulling f1259d8 on ConnorDoyle:dashboard-serviceaccount into 91169fd on tensorflow:master.

ScorpioCPH

@ConnorDoyle Thanks for your PR, LGTM :)

* Some lint checks have crept in due to #274 * Fix #298 (py lint issues) * Need to exclude some of the dependencies used by the frontend. * Fix util.run so that the output of commands prints out in airflow We need to redirect subprocess to a file and then read the file; nothing else seems to work. * Delete the test e2e_tests_dag_test.py; this was failing because of the way we import util and try to mock it out. Not worth fixing since we plan on getting rid of Airflow.

ConnorDoyle · 2018-01-13T17:37:31Z

@jlewi I believe this PR was accidentally referenced in another PR (#303). This PR isn’t related to pylint.

jlewi · 2018-01-13T22:11:39Z

My mistake thanks;

jlewi · 2018-01-13T22:14:12Z

@ConnorDoyle Can you sync please so we can get test results with the latest changes? I suspect this is still blocked by #293.

coveralls · 2018-01-13T22:21:08Z

Coverage remained the same at 31.609% when pulling f1259d8 on ConnorDoyle:dashboard-serviceaccount into 91169fd on tensorflow:master.

jlewi · 2018-01-16T12:53:36Z

@ConnorDoyle Head is now fixed, can you sync and update the PR so we can get latest test results?

ConnorDoyle · 2018-01-16T18:49:47Z

Rebased

jlewi · 2018-01-16T22:52:56Z

/test all

jlewi · 2018-01-17T00:37:11Z

Only 7 of the tests ran because setup cluster failed. I think this is unrelated to our PRs and has to do with an issue in our test-infra.

jlewi · 2018-01-17T00:37:16Z

/test all

jlewi · 2018-01-17T05:55:57Z

Not sure what's going on with travis; doesn't look like one of the travis builds ran. Since our presubmit job ran successfully I'm going to merge this.

coveralls · 2018-01-17T06:59:30Z

Coverage remained the same at 31.541% when pulling b382c4c on ConnorDoyle:dashboard-serviceaccount into 357a509 on tensorflow:master.

ScorpioCPH reviewed Jan 12, 2018

View reviewed changes

jlewi mentioned this pull request Jan 12, 2018

Fix Head #293

Closed

4 tasks

jlewi added a commit to jlewi/k8s that referenced this pull request Jan 12, 2018

Fix python lint checks

f706b2f

* Some lint checks have crept in due to kubeflow#274 * Fix kubeflow#298 (py lint issues) * Need to exclude some of the dependencies used by the frontend.

jlewi mentioned this pull request Jan 12, 2018

Fix python lint checks #303

Merged

ConnorDoyle force-pushed the dashboard-serviceaccount branch from fd6ad00 to f1259d8 Compare January 13, 2018 06:09

ScorpioCPH approved these changes Jan 13, 2018

View reviewed changes

jlewi closed this in #303 Jan 13, 2018

jlewi reopened this Jan 13, 2018

Add service account name to dashboard if RBAC.

b382c4c

ConnorDoyle force-pushed the dashboard-serviceaccount branch from f1259d8 to b382c4c Compare January 16, 2018 18:49

jlewi merged commit 19e5e22 into kubeflow:master Jan 17, 2018

ConnorDoyle deleted the dashboard-serviceaccount branch January 17, 2018 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add service account name to dashboard if RBAC. #298

Add service account name to dashboard if RBAC. #298

ConnorDoyle commented Jan 12, 2018 •

edited by jlewi

Loading

googlebot commented Jan 12, 2018

coveralls commented Jan 12, 2018 •

edited

Loading

ScorpioCPH Jan 12, 2018

ConnorDoyle Jan 12, 2018

ConnorDoyle commented Jan 12, 2018

googlebot commented Jan 12, 2018

ConnorDoyle commented Jan 13, 2018

coveralls commented Jan 13, 2018 •

edited

Loading

ScorpioCPH left a comment

ConnorDoyle commented Jan 13, 2018

jlewi commented Jan 13, 2018

jlewi commented Jan 13, 2018

coveralls commented Jan 13, 2018 •

edited

Loading

jlewi commented Jan 16, 2018

ConnorDoyle commented Jan 16, 2018

jlewi commented Jan 16, 2018

jlewi commented Jan 17, 2018

jlewi commented Jan 17, 2018

jlewi commented Jan 17, 2018

coveralls commented Jan 17, 2018

Add service account name to dashboard if RBAC. #298

Add service account name to dashboard if RBAC. #298

Conversation

ConnorDoyle commented Jan 12, 2018 • edited by jlewi Loading

googlebot commented Jan 12, 2018

coveralls commented Jan 12, 2018 • edited Loading

ScorpioCPH Jan 12, 2018

Choose a reason for hiding this comment

ConnorDoyle Jan 12, 2018

Choose a reason for hiding this comment

ConnorDoyle commented Jan 12, 2018

googlebot commented Jan 12, 2018

ConnorDoyle commented Jan 13, 2018

coveralls commented Jan 13, 2018 • edited Loading

ScorpioCPH left a comment

Choose a reason for hiding this comment

ConnorDoyle commented Jan 13, 2018

jlewi commented Jan 13, 2018

jlewi commented Jan 13, 2018

coveralls commented Jan 13, 2018 • edited Loading

jlewi commented Jan 16, 2018

ConnorDoyle commented Jan 16, 2018

jlewi commented Jan 16, 2018

jlewi commented Jan 17, 2018

jlewi commented Jan 17, 2018

jlewi commented Jan 17, 2018

coveralls commented Jan 17, 2018

ConnorDoyle commented Jan 12, 2018 •

edited by jlewi

Loading

coveralls commented Jan 12, 2018 •

edited

Loading

coveralls commented Jan 13, 2018 •

edited

Loading

coveralls commented Jan 13, 2018 •

edited

Loading