Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete binary file #331

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Delete binary file #331

merged 1 commit into from
Jan 20, 2018

Conversation

ScorpioCPH
Copy link
Member

@ScorpioCPH ScorpioCPH commented Jan 19, 2018 •
edited by jlewi
Loading

This PR remove binary file which should not be checked into git repo.

@jlewi @gaocegege @DjangoPeng PTAL.

This change is Reviewable

@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 31.439% when pulling 351e0fb on ScorpioCPH:delete-binary-file into 04425d9 on tensorflow:master.

gaocegege
gaocegege reviewed Jan 19, 2018
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I think we could add an item in gitignore file

@DjangoPeng
Copy link
Member

@gaocegege @ScorpioCPH We could add a Makefile to standardise the process of making binary file. I'd like to pick it up.

DjangoPeng
DjangoPeng approved these changes Jan 19, 2018
View reviewed changes
Copy link
Member

@DjangoPeng DjangoPeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jan 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 31.439% when pulling 4884769 on ScorpioCPH:delete-binary-file into 04425d9 on tensorflow:master.

@ScorpioCPH
Copy link
Member Author

Makefile is great, and here is a guide for build it on local: building-all-the-artifacts

@jlewi jlewi merged commit c8b9368 into kubeflow:master Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@DjangoPeng DjangoPeng DjangoPeng approved these changes

@jlewi jlewi jlewi approved these changes

@jimexist jimexist jimexist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ScorpioCPH @coveralls @DjangoPeng @jimexist @jlewi @gaocegege