Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local releaser #361

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Fix local releaser #361

merged 1 commit into from
Feb 2, 2018

Conversation

jose5918
Copy link
Contributor

@jose5918 jose5918 commented Jan 31, 2018

Changes made:

  • Moved version_tag to the common args to fix local release

Intended to fix #360


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @jose5918. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 31.856% when pulling 5f9d57e on jose5918:fix_local_releaser into 330eb92 on tensorflow:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 31.856% when pulling 5f9d57e on jose5918:fix_local_releaser into 330eb92 on tensorflow:master.

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

We can merge this as soon as the tests pass.

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

I suspect test failures might be an issue with our test-infrastructure. I'm working to get us ported over to Argo which should hopefully make it much better. At the very least logs will be readily accessible.

@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

/test all

@jlewi jlewi merged commit 95d9a3f into kubeflow:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local releaser fails due to version_tag
4 participants