Add a prow_config.yaml file to configure our prow jobs. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See kubeflow/testing#12 * Our prow jobs will trigger a script that will process prow_config.yaml and figure out which workflows to run. * This will allow us to easily run multiple workflows as part of our E2E tests.
|
/test all |
5 similar comments
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test all |
This was referenced Feb 13, 2018
|
The test failures are due to kubeflow/testing#30 |
jlewi
changed the title
|
@gaocegege @lluunn This is ready for review. The tests are passing; the failure is due to kubeflow/testing#30. |
|
/test all |
1 similar comment
|
/test all |
gaocegege
reviewed
Feb 15, 2018
| @@ -8,7 +8,7 @@ | |||
| // Each object below should correspond to a component in the components/ directory | |||
| workflows: { | |||
| bucket: "mlkube-testing_temp", | |||
| name: "jlewi-tf-k8s-presubmit-test-374-6e32", | |||
| name: "some-very-very-very-very-very-long-name-jlewi-tf-k8s-presubmit-test-374-6e32", | |||
There was a problem hiding this comment.
Why do we need a very very very long name 🤔
|
/test al |
|
/test all |
|
Woo Hoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See checkout.sh should support checking out extra repositories. testing#12
Our prow jobs will trigger a script that will process prow_config.yaml
and figure out which workflows to run.
This will allow us to easily run multiple workflows as part of our E2E tests.
Fix one source of flakiness in TFJob test
to fail with a very cryptic error message
This change is