Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an initial OWNERS file. #414

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Create an initial OWNERS file. #414

merged 1 commit into from
Feb 27, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Feb 27, 2018 •
edited
Loading

This change is Reviewable

@jlewi
Create an initial OWNERS file.
5586fe3 
* This will hopefully help us spread the review, approve workload around.
* Related to
kubeflow/community#10
@jlewi jlewi requested a review from gaocegege February 27, 2018 12:55
jimexist
jimexist approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@jimexist jimexist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does every user name start with @?

@jimexist
Copy link
Member

also the file can be hierarchy, having subdirectory file overriding upper level one

@coveralls
Copy link

coveralls commented Feb 27, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 31.978% when pulling 5586fe3 on jlewi:owners into 0094aaa on kubeflow:master.

@jlewi
Copy link
Contributor Author

jlewi commented Feb 27, 2018

@jimexist doesn't look like '@' should be used in usernames.
https://github.com/kubernetes/test-infra/blob/master/OWNERS

@jimexist I agree it might make sense to have overrides in subdirectories (e.g. for the UI). But I thought we'd start simple.

@jlewi jlewi merged commit a814670 into kubeflow:master Feb 27, 2018
@gaocegege
Copy link
Member

I agree it might make sense to have overrides in subdirectories (e.g. for the UI). But I thought we'd start simple.

I can file an issue for it

This was referenced Feb 27, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

@jimexist jimexist jimexist approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlewi @jimexist @coveralls @gaocegege @k8s-ci-robot