New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service_control: Set owner ref for service and add test cases #617

Merged

k8s-ci-robot merged 2 commits into kubeflow:master from gaocegege:test

Jun 4, 2018

Member

gaocegege commented Jun 1, 2018 •

edited by jlewi

Loading

Close #616

We do not set owner reference for the service in servicecontrol, thus we can not get all services by the given tfjob. This PR adds the logic and corresponding test cases.

/assign @jlewi

This change is

k8s-ci-robot assigned jlewi

k8s-ci-robot requested review from lluunn and vishh

June 1, 2018 06:55

k8s-ci-robot added size/XXL size/M and removed size/XXL labels

coveralls commented Jun 1, 2018 •

edited

Loading

Coverage increased (+3.3%) to 57.214% when pulling 867931b on gaocegege:test into 0be3b81 on kubeflow:master.

TravisBuddy commented Jun 1, 2018

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...

pkg/controller.v2/service_control.go:94:20:warning: this value of err is never used (SA4006) (staticcheck)

3rd Build

gometalinter --config=linter_config.json --vendor ./...

pkg/controller.v2/service_control.go:94:20:warning: this value of err is never used (SA4006) (staticcheck)

travis_time:end:01b0b678:start=1527836234793639017,finish=1527836361889929332,duration=127096290315

TravisBuddy commented Jun 1, 2018

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

gometalinter --config=linter_config.json --vendor ./...

dashboard/backend/handler/api_handler.go:1::warning: file is not goimported (goimports)
pkg/controller.v2/service_control.go:94:20:warning: this value of err is never used (SA4006) (staticcheck)

3rd Build

gometalinter --config=linter_config.json --vendor ./...

pkg/controller.v2/service_control.go:94:20:warning: this value of err is never used (SA4006) (staticcheck)

travis_time:end:0553f6bc:start=1527837431053045399,finish=1527837536620799543,duration=105567754144

TravisBuddy commented Jun 1, 2018

Travis tests have failed

Hey @gaocegege,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

gometalinter --config=linter_config.json --vendor ./...

dashboard/backend/handler/api_handler.go:1::warning: file is not goimported (goimports)

travis_time:end:1a62a817:start=1527838652724544354,finish=1527838775865751421,duration=123141207067

2nd Build

gometalinter --config=linter_config.json --vendor ./...

dashboard/backend/handler/api_handler.go:1::warning: file is not goimported (goimports)

Contributor

jlewi commented Jun 1, 2018

/lgtm
except for failing tests

k8s-ci-robot added the lgtm label

gaocegege added 2 commits

June 4, 2018 15:46


          service_control: Set owner ref for service

923dae6

Signed-off-by: Ce Gao <gaoce@caicloud.io>


          service_control: Add err check

867931b

Signed-off-by: Ce Gao <gaoce@caicloud.io>

k8s-ci-robot commented Jun 4, 2018

New changes are detected. LGTM label has been removed.

k8s-ci-robot removed the lgtm label

gaocegege added lgtm approved labels

k8s-ci-robot commented Jun 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot merged commit 93843ed into kubeflow:master

yph152 pushed a commit to yph152/tf-operator that referenced this pull request


          service_control: Set owner ref for service and add test cases (kubefl…

868d914

…ow#617)

* service_control: Set owner ref for service

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* service_control: Add err check

Signed-off-by: Ce Gao <gaoce@caicloud.io>

jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request


          service_control: Set owner ref for service and add test cases (kubefl…

680da01

…ow#617)

* service_control: Set owner ref for service

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* service_control: Add err check

Signed-off-by: Ce Gao <gaoce@caicloud.io>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/M