Fix the E2E test by specifying cloud when deploying the helm package. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We need to specify the cloud flag when deploying the helm package so the a volume is properly created with the TfJob config. * This should fix issue/96 * run functions in util.py should capture stderr in addition to stdout so we get the output from help-test * Thi sshould fix issue/95
This was referenced Oct 29, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to specify the cloud flag when deploying the helm package so
the a volume is properly created with the TfJob config.
run functions in util.py should capture stderr in addition to stdout so
we get the output from help-test
Add an option to helm-test not to purge the helm release; this can help manually debugging.