Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright header is not correctly generated #1309

Closed
Jeffwan opened this issue Jul 29, 2021 · 10 comments
Closed

Copyright header is not correctly generated #1309

Jeffwan opened this issue Jul 29, 2021 · 10 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Jul 29, 2021

https://github.com/kubeflow/tf-operator/blob/b8d5d3cd6e824865de196388c2c2a4e852b709e7/pkg/controller.v1/mxnet/mxjob_controller.go#L1

https://github.com/kubeflow/tf-operator/blob/b8d5d3cd6e824865de196388c2c2a4e852b709e7/main.go#L2

Seems hack scripts doesn't correctly generate hear and render it in files

/help
/good-first-issue

@google-oss-robot
Copy link

@Jeffwan:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

https://github.com/kubeflow/tf-operator/blob/b8d5d3cd6e824865de196388c2c2a4e852b709e7/pkg/controller.v1/mxnet/mxjob_controller.go#L1

Seems hack scripts doesn't correctly generate hear and render it in files

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 5, 2021

/cc @PatrickXYS If you have interest, feel free to pick them up.

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 6, 2021

/assign @PatrickXYS

@Jeffwan Jeffwan changed the title Copyright header is not correctly generated in all-in-one-operator branch Copyright header is not correctly generated Aug 16, 2021
@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 17, 2021

@DeliangFan reached out to me and he wants to pick up some beginner issues in this repo. This would be a good candidate. @PatrickXYS I will unassign you and I know you will be busy with onboarding. :D

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 17, 2021

/assign @DeliangFan

@google-oss-robot
Copy link

@Jeffwan: GitHub didn't allow me to assign the following users: DeliangFan.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @DeliangFan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DeliangFan
Copy link
Contributor

/assing

@DeliangFan
Copy link
Contributor

/assign

@DeliangFan
Copy link
Contributor

@DeliangFan reached out to me and he wants to pick up some beginner issues in this repo. This would be a good candidate. @PatrickXYS I will unassign you and I know you will be busy with onboarding. :D

Thanks Jeffwan a lot~

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 17, 2021

Thanks @DeliangFan for the help!

@Jeffwan Jeffwan closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants