Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should training operator keep clientset in the same repository? #1332

Closed
Jeffwan opened this issue Aug 4, 2021 · 4 comments
Closed

Should training operator keep clientset in the same repository? #1332

Jeffwan opened this issue Aug 4, 2021 · 4 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Aug 4, 2021

There's discussion with @andreyvelich here #1320 (comment)
@zw0610 also mentioned this when we start all-one-one operator project.

it depends on whether we have upstream, (I do think so. ) Having separate repo is easier for any project to import and that's pretty clean. Otherwise, user have to import entire project which is still acceptable and they need to take care of the dependencies.

While, it might be hard for us to open a new repo for training apis. Probably good for all kubeflow apis?

@zw0610
Copy link
Member

zw0610 commented Aug 4, 2021

I think the main point is to separate apis and clientsets. The generation of clientsets introduces a specific client-go version, which maybe troublesome for developers on client-go version control.

@gaocegege
Copy link
Member

I think the main point is to separate apis and clientsets. The generation of clientsets introduces a specific client-go version, which maybe troublesome for developers on client-go version control.

Do you mean we need three repos?

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 6, 2021

/kind discussion

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants