Missing Pod label for Service selector

[SharpEdgeMarshall]

After this change 46c5864 the service use this selector: name: training-operator but there is no such label on pod.

[Jeffwan]

em. I can verify this is a bug. Since deployment use generated name, it doesn't have the name: training-operator in the pod. We should have a different label like component: training-operator or use other labels as identifier.

@SharpEdgeMarshall @deepak-muley Can you help fix it?

training-operator-5f44787bdf-b2cpk
Name:         training-operator-5f44787bdf-b2cpk
Namespace:    kubeflow
Priority:     0
Node:         docker-desktop/192.168.65.4
Start Time:   Mon, 06 Sep 2021 10:24:24 -0700
Labels:       control-plane=kubeflow-training-operator
              pod-template-hash=5f44787bdf

[SharpEdgeMarshall]

@Jeffwan can't we simply add a label name: training-operator?

If you see, before that commit there was a label name: tf-job-operator service and deployment

For reference this is the fix I'm using ATM:

# Fix for https://github.com/kubeflow/tf-operator/issues/1399
def fix_1399(obj, opts):
    if obj["kind"] == "Deployment" and obj["metadata"]["name"] == "training-operator":
        obj["spec"]["template"]["metadata"]["labels"]["name"] = "training-operator"

[Jeffwan]

@SharpEdgeMarshall I think we can. Adding name: training-operator or reusing existing one sounds good to me.

This is current label.

  labels:
    control-plane: kubeflow-training-operator

can you help file a PR to address the issue. Thanks!

[Jeffwan]

/kind bug

[deepak-muley]

/assign

[Jeffwan]

@deepak-muley Do you get a chance to update the label? kubeflow/manifests#2018

[deepak-muley]

I will get a PR out today. Sorry for the delay.

[Jeffwan]

/close

[google-oss-robot]

@Jeffwan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.