-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Create Job From Docker API #1878
Comments
+1 for ease of use. Although I would avoid mentioning "docker" which is implementation specific. |
Makes sense, any suggestions @terrytangyuan (e.g. |
What about |
Makes sense, so just provide users 1 API called |
Yep exactly this will avoid exploding the list of public APIs. |
It's a good idea. SGTM
In future work, it might be better to add parameters to define if push built image to the registry. |
/cc @gaocegege |
/assign @andreyvelich |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/lifecycle frozen |
Previously, we created
create_job_from_func
API: #1659.This API is useful for users who want to quickly convert their training function to a Kubeflow Distributed Training Job, but it is hard to be used for large models since all import/code should be self-contained.
Similar to KFP Containerized Python Components, we can introduce a new API called:
create_job_from_docker
which helps user converts their training code to a Kubeflow Training Job.Initially, we can have the following signature:
Which is simply constructing Training Job using base image.
In the future, we can introduce
target_image
,packages_to_install
, etc. parameters which allows SDK to build Docker image on a fly using Docker client.User requires to run docker daemon to use it.
Related: kubeflow/common#66.
What do you think @kubeflow/wg-training-leads @tenzen-y @kuizhiqing @yaobaiwei @zw0610 @droctothorpe ?
The text was updated successfully, but these errors were encountered: