-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TfPort and set default port for users #327
Comments
Now our pod template spec is not required because we have TfImage and TfPort, if we deprecate it, we should add validation and defaults. |
+1. For validation we should look at the validation features now available with CRDs. I think we can provide an OpenAPi spec and it will K8s will automatically validate specs. |
I like the idea! The feature is beta in v1.9. I think we should update the requirement in this repo and kubeflow if we use it. |
/assign gaocegege |
Opened #437 to use OpenAPI validation. |
Do you think we should fix this issue or just wait for the V2 APi (kubeflow/community#30)? My vote would be for fixing it as part of the v2 API. |
I will fix the issue in v1alpha2 😄 |
Closed by #492 |
In the current CRD, we have a
TfPort
field here for TensorFlow replicas. While the pod template has aPort
field as well.According to the discussion of
TfPort
here, we'd like to deprecate it and set a default port for users./cc @jlewi @gaocegege @ScorpioCPH
The text was updated successfully, but these errors were encountered: