Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TfPort and set default port for users #327

Closed
DjangoPeng opened this issue Jan 19, 2018 · 8 comments
Closed

Deprecate TfPort and set default port for users #327

DjangoPeng opened this issue Jan 19, 2018 · 8 comments

Comments

@DjangoPeng
Copy link
Member

DjangoPeng commented Jan 19, 2018

In the current CRD, we have a TfPort field here for TensorFlow replicas. While the pod template has a Port field as well.

According to the discussion of TfPort here, we'd like to deprecate it and set a default port for users.

/cc @jlewi @gaocegege @ScorpioCPH

@gaocegege
Copy link
Member

Now our pod template spec is not required because we have TfImage and TfPort, if we deprecate it, we should add validation and defaults.

@jlewi
Copy link
Contributor

jlewi commented Feb 16, 2018

+1.

For validation we should look at the validation features now available with CRDs. I think we can provide an OpenAPi spec and it will K8s will automatically validate specs.

@gaocegege
Copy link
Member

gaocegege commented Feb 16, 2018

@jlewi

I like the idea! The feature is beta in v1.9. I think we should update the requirement in this repo and kubeflow if we use it.

@gaocegege
Copy link
Member

/assign gaocegege

@jlewi
Copy link
Contributor

jlewi commented Mar 7, 2018

Opened #437 to use OpenAPI validation.

@jlewi
Copy link
Contributor

jlewi commented Mar 7, 2018

Do you think we should fix this issue or just wait for the V2 APi (kubeflow/community#30)? My vote would be for fixing it as part of the v2 API.

@gaocegege
Copy link
Member

I will fix the issue in v1alpha2 😄

@gaocegege
Copy link
Member

Closed by #492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants