Make coverall results advisory and not report as failure

[jlewi]

Right now if test coverage decreases (even slightly) coveralls reports this as a failure and the PR is marked as having failures.

I find this distracting in that it makes it harder to see which PRs are ready to review/merge.

Can we make coveralls advisory so that it reports test coverage results to GitHub but doesn't report a failure if there is a decrease?

[gaocegege]

I tried but I have no access to the settings, you could update it in https://coveralls.io/github/kubeflow/tf-operator/settings.

[jlewi]

I changed coverage decrease threshold for failure to 20%.

What is the coverage threshold for failure?

[gaocegege]

If we set coverage threshold to 20%, and our code coverage is 19%, then it will report a failure.

If we set coverage decrease threshold to 20%, and one PR decrease the coverage from 100% to 79%, then it will report a failure.

Then I think we could set all these two to 20%

[jlewi]

I see, coverage threshold is blank right now. Lets see what happens.

[jlewi]

Coveralls is no longer reporting failure see
#403 (comment)

[PrincewillIroka]

I reduced both COVERAGE THRESHOLD FOR FAILURE and COVERAGE DECREASE THRESHOLD FOR FAILURE to 0.0% and Coveralls Coverage no longer fails.