New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[log] investigate zap #534

Closed

gaocegege opened this issue Apr 12, 2018 · 1 comment

Labels

area/logging kind/enhancement priority/p3

Member

gaocegege commented Apr 12, 2018 •

edited

Loading

zap has a better performance than logrus for structural logging. There is an evaluation https://github.com/uber-go/zap#performance

https://github.com/uber-go/zap

gaocegege added kind/enhancement priority/p3 area/logging labels

Member Author

gaocegege commented Jun 14, 2018

zap is fast while I do not think logging is a bottleneck, thus close the issue.

gaocegege closed this as completed

gaocegege mentioned this issue

Enrich logging kubeflow/katib#112

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment