Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Remove Final Keyword from constants #1676

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 34 additions & 37 deletions sdk/python/kubeflow/training/constants/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,63 +13,60 @@
# limitations under the License.

import os
from typing import Final

# General constants
# How long to wait in seconds for requests to the ApiServer
APISERVER_TIMEOUT: Final[int] = 120
KUBEFLOW_GROUP: Final[str] = "kubeflow.org"
APISERVER_TIMEOUT = 120
KUBEFLOW_GROUP = "kubeflow.org"

# TFJob K8S constants
TFJOB_KIND: Final[str] = "TFJob"
TFJOB_PLURAL: Final[str] = "tfjobs"
TFJOB_VERSION: Final[str] = os.environ.get("TFJOB_VERSION", "v1")
TFJOB_KIND = "TFJob"
TFJOB_PLURAL = "tfjobs"
TFJOB_VERSION = os.environ.get("TFJOB_VERSION", "v1")

TFJOB_LOGLEVEL: Final[str] = os.environ.get("TFJOB_LOGLEVEL", "INFO").upper()
TFJOB_LOGLEVEL = os.environ.get("TFJOB_LOGLEVEL", "INFO").upper()

TFJOB_BASE_IMAGE: Final[str] = "docker.io/tensorflow/tensorflow:2.9.1"
TFJOB_BASE_IMAGE_GPU: Final[str] = "docker.io/tensorflow/tensorflow:2.9.1-gpu"
TFJOB_BASE_IMAGE = "docker.io/tensorflow/tensorflow:2.9.1"
TFJOB_BASE_IMAGE_GPU = "docker.io/tensorflow/tensorflow:2.9.1-gpu"

# Job Label Names
JOB_GROUP_LABEL: Final[str] = "group-name"
JOB_NAME_LABEL: Final[str] = "training.kubeflow.org/job-name"
JOB_TYPE_LABEL: Final[str] = "training.kubeflow.org/replica-type"
JOB_INDEX_LABEL: Final[str] = "training.kubeflow.org/replica-index"
JOB_ROLE_LABEL: Final[str] = "training.kubeflow.org/job-role"
JOB_ROLE_MASTER: Final[str] = "master"
JOB_GROUP_LABEL = "group-name"
JOB_NAME_LABEL = "training.kubeflow.org/job-name"
JOB_TYPE_LABEL = "training.kubeflow.org/replica-type"
JOB_INDEX_LABEL = "training.kubeflow.org/replica-index"
JOB_ROLE_LABEL = "training.kubeflow.org/job-role"
JOB_ROLE_MASTER = "master"

JOB_STATUS_SUCCEEDED: Final[str] = "Succeeded"
JOB_STATUS_FAILED: Final[str] = "Failed"
JOB_STATUS_RUNNING: Final[str] = "Running"
JOB_STATUS_SUCCEEDED = "Succeeded"
JOB_STATUS_FAILED = "Failed"
JOB_STATUS_RUNNING = "Running"

# PyTorchJob K8S constants
PYTORCHJOB_KIND: Final[str] = "PyTorchJob"
PYTORCHJOB_PLURAL: Final[str] = "pytorchjobs"
PYTORCHJOB_VERSION: Final[str] = os.environ.get("PYTORCHJOB_VERSION", "v1")
PYTORCHJOB_KIND = "PyTorchJob"
PYTORCHJOB_PLURAL = "pytorchjobs"
PYTORCHJOB_VERSION = os.environ.get("PYTORCHJOB_VERSION", "v1")

PYTORCH_LOGLEVEL: Final[str] = os.environ.get("PYTORCHJOB_LOGLEVEL", "INFO").upper()
PYTORCH_LOGLEVEL = os.environ.get("PYTORCHJOB_LOGLEVEL", "INFO").upper()

PYTORCHJOB_BASE_IMAGE: Final[
str
] = "docker.io/pytorch/pytorch:1.12.1-cuda11.3-cudnn8-runtime"
PYTORCHJOB_BASE_IMAGE = "docker.io/pytorch/pytorch:1.12.1-cuda11.3-cudnn8-runtime"

# XGBoostJob K8S constants
XGBOOSTJOB_KIND: Final[str] = "XGBoostJob"
XGBOOSTJOB_PLURAL: Final[str] = "xgboostjobs"
XGBOOSTJOB_VERSION: Final[str] = os.environ.get("XGBOOSTJOB_VERSION", "v1")
XGBOOSTJOB_KIND = "XGBoostJob"
XGBOOSTJOB_PLURAL = "xgboostjobs"
XGBOOSTJOB_VERSION = os.environ.get("XGBOOSTJOB_VERSION", "v1")

XGBOOST_LOGLEVEL: Final[str] = os.environ.get("XGBOOSTJOB_LOGLEVEL", "INFO").upper()
XGBOOST_LOGLEVEL = os.environ.get("XGBOOSTJOB_LOGLEVEL", "INFO").upper()

# MPIJob K8S constants
MPIJOB_KIND: Final[str] = "MPIJob"
MPIJOB_PLURAL: Final[str] = "mpijobs"
MPIJOB_VERSION: Final[str] = os.environ.get("MPIJOB_VERSION", "v1")
MPIJOB_KIND = "MPIJob"
MPIJOB_PLURAL = "mpijobs"
MPIJOB_VERSION = os.environ.get("MPIJOB_VERSION", "v1")

MPI_LOGLEVEL: Final[str] = os.environ.get("MPIJOB_LOGLEVEL", "INFO").upper()
MPI_LOGLEVEL = os.environ.get("MPIJOB_LOGLEVEL", "INFO").upper()

# MXNETJob K8S constants
MXJOB_KIND: Final[str] = "MXJob"
MXJOB_PLURAL: Final[str] = "mxjobs"
MXJOB_VERSION: Final[str] = os.environ.get("MXJOB_VERSION", "v1")
MXJOB_KIND = "MXJob"
MXJOB_PLURAL = "mxjobs"
MXJOB_VERSION = os.environ.get("MXJOB_VERSION", "v1")

MX_LOGLEVEL: Final[str] = os.environ.get("MXJOB_LOGLEVEL", "INFO").upper()
MX_LOGLEVEL = os.environ.get("MXJOB_LOGLEVEL", "INFO").upper()