Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change node autoscaler setup logic #6699

Open
csengerszabo opened this issue May 28, 2024 · 4 comments
Open

Change node autoscaler setup logic #6699

csengerszabo opened this issue May 28, 2024 · 4 comments
Labels
kind/enhancement sig/api Denotes a PR or issue as being assigned to SIG API. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/ui Denotes a PR or issue as being assigned to SIG UI.
Milestone

Comments

@csengerszabo
Copy link
Contributor

csengerszabo commented May 28, 2024

In step 4 of cluster creation at the Node Autoscaling part, there is a helper text saying: Enable "cluster-austoscaler" addon to apply these changes

If the addon is needed, and since this step is before we can add any addons to the cluster, it’s not logical to set this here.

Instead:

  1. we can either set Node Autoscaler in the addon later
  2. or enable the add-on previously in Step 2 under the Specifications section, then display this setting depending on the autoscaler was enabled previously

Option 2 is preferred.

@csengerszabo csengerszabo added the sig/ui Denotes a PR or issue as being assigned to SIG UI. label May 28, 2024
@csengerszabo csengerszabo added this to the KKP 2.26 milestone May 28, 2024
@csengerszabo
Copy link
Contributor Author

Evaluate if it’s possible to convert node autoscaler addon into an application, which will solve the UI logic since an application can be managed during cluster creation time

@ahmedwaleedmalik
Copy link
Member

This parts need to be automated in a way that it's injected by KKP.

@csengerszabo csengerszabo added the sig/app-management Denotes a PR or issue as being assigned to SIG App Management. label Jul 3, 2024
@csengerszabo
Copy link
Contributor Author

  • Setting up the autoscaler on the machine-deployments page on the UI
  • If the check-box is selected, the application will automatically be added
  • Implement simple templating for applicationDefinitions / installations considering the K8s version of the cluster
  • Building the autoscaler Helm chart

@csengerszabo csengerszabo added kind/enhancement sig/api Denotes a PR or issue as being assigned to SIG API. labels Jul 9, 2024
@csengerszabo
Copy link
Contributor Author

/milestone clear

@kubermatic-bot kubermatic-bot removed this from the KKP 2.26 milestone Aug 22, 2024
@csengerszabo csengerszabo added this to the KKP 2.27 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement sig/api Denotes a PR or issue as being assigned to SIG API. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. sig/ui Denotes a PR or issue as being assigned to SIG UI.
Projects
None yet
Development

No branches or pull requests

3 participants