Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node local DNS cache #704

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Node local DNS cache #704

merged 2 commits into from
Oct 18, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Oct 17, 2019

What this PR does / why we need it:
Minimal (for now only for install workflow) node local DNS cache.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #389

Does this PR introduce a user-facing change?:

Node local DNS cache

@kron4eg
Node local DNS cache
9090125 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg requested a review from xmudrii October 17, 2019 14:49
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 17, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2019
@kron4eg kron4eg mentioned this pull request Oct 17, 2019
Closed
@kron4eg kron4eg changed the title WIP Node local DNS cache Node local DNS cache Oct 17, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2019
@kron4eg
Add missing machinecontroller -cluster-dns flag
626ccbe 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg added this to the v0.11 milestone Oct 17, 2019
xmudrii
xmudrii approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7702a634899e3e375761b6a2e8b55cbc2d0663d0

@kubermatic-bot kubermatic-bot merged commit 646f05a into master Oct 18, 2019
@kubermatic-bot kubermatic-bot deleted the 389-node-local-dns-cache-3 branch October 18, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.

Add nodelocal dns cache
3 participants
@kron4eg @kubermatic-bot @xmudrii