Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure-cloud-routes = false on AWS #725

Merged
merged 1 commit into from
Nov 4, 2019
Merged

configure-cloud-routes = false on AWS #725

merged 1 commit into from
Nov 4, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Oct 30, 2019

What this PR does / why we need it:
Fixes log spamming regarding cloud-routes on AWS

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #627

Fix AWS configure-cloud-routes bug

@kron4eg
configure-cloud-routes = false on AWS
e36bfee 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg requested a review from xmudrii October 30, 2019 15:34
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 30, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Oct 30, 2019

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Oct 30, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Oct 30, 2019

/rest

@kron4eg
Copy link
Member Author

kron4eg commented Oct 30, 2019

/retest

xmudrii
xmudrii requested changes Oct 30, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is an option because we'll not be able to use all cloud features, such as type: LoadBalancer Services. This is a similar problem we had with GCE too.

For instance, creating a LoadBalancer Service fails with:

  Normal   EnsuringLoadBalancer      2m18s (x7 over 7m37s)  service-controller  Ensuring load balancer
  Warning  SyncLoadBalancerFailed    2m17s (x4 over 7m35s)  service-controller  Error syncing load balancer: failed to ensure load balancer: Multiple tagged security groups found for instance i-<id>; ensure only the k8s security group is tagged; the tagged groups were sg-<id-1>(<name-1>) sg-<id-2>(<name-2>)
  Warning  UpdateLoadBalancerFailed  48s (x3 over 7m29s)    service-controller  Error updating load balancer with new hosts map[<node-1-name>:{} <node-2-name>:{} <node-3-name>:{}]: Multiple tagged security groups found for instance i-<id>; ensure only the k8s security group is tagged; the tagged groups were sg-<id-1>(<name-1>) sg-<id-2>(<name-2>)

kube-controller-manager logs show the same, however, there is also this:

W1030 17:30:19.345638       1 aws.go:3255] No tagged subnets found; will fall-back to the current subnet only.  This is likely to be an error in a future version of k8s.

The only proper way to solve this is to properly tag our resources, otherwise, we are just going to run into more and more problems. Once we do that, type: LoadBalancer Services should start to work again, but also, the annoying logs from kube-controller-manager should be gone.

@kron4eg
Copy link
Member Author

kron4eg commented Nov 2, 2019

/retest

xmudrii
xmudrii approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 44ea1b2916631ff27430f2938cda252318bcc2c5

@kubermatic-bot kubermatic-bot merged commit ab452cf into kubermatic:master Nov 4, 2019
@kubermatic-bot kubermatic-bot added this to the v0.11 milestone Nov 4, 2019
@kron4eg kron4eg deleted the aws-cloud-routes branch November 4, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.

add configure-cloud-routes = false to aws configuration
3 participants
@kron4eg @kubermatic-bot @xmudrii