Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubeconfig should not require certificate authority data for well known CAs. #220

Closed
twitchax opened this issue Nov 30, 2018 · 4 comments
Closed

Kubeconfig should not require certificate authority data for well known CAs. #220

twitchax opened this issue Nov 30, 2018 · 4 comments

Comments

@twitchax
Copy link
Contributor

As the title says, the parser for the kubeconfig is too sensitive for certificate authority data.

kubectl will allow a blank entry if the CA is well-known (e.g., LetsEncrypt CA). The code here prevents that scenario.
@twitchax twitchax changed the title Kubeconfig requires certificate authority data for well known CAs. Kubeconfig should not require certificate authority data for well known CAs. Nov 30, 2018
@brendandburns
Copy link
Contributor

Agree that makes sense. I'd be happy for a PR or I can get to this eventually myself...

@twitchax
Copy link
Contributor Author

twitchax commented Dec 2, 2018

I don't mind doing it.

Do we want to check the well-known-ness of the CA, or should we just let it fail during negotiation?

@brendandburns
Copy link
Contributor

I would just let it fail (I'm not sure there is a way to test it prior to making the call)

Thanks! (and sorry for the delay in responding)

@twitchax twitchax mentioned this issue Dec 6, 2018
Merged
@brendandburns
Copy link
Contributor

Fixed by #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twitchax @brendandburns