Merge pull request #2115 from yue9944882/deprecate-no-args-informer-factory

Deprecating no-arg informer-factory

Author: k8s-ci-robot

examples/examples-release-13/src/main/java/io/kubernetes/client/examples/InformerExample.java

@@ -41,12 +41,16 @@ public static void main(String[] args) throws Exception {
         apiClient.getHttpClient().newBuilder().readTimeout(0, TimeUnit.SECONDS).build();
     apiClient.setHttpClient(httpClient);
 
-    SharedInformerFactory factory = new SharedInformerFactory();
+    SharedInformerFactory factory = new SharedInformerFactory(apiClient);
 
     // Node informer
     SharedIndexInformer<V1Node> nodeInformer =
         factory.sharedIndexInformerFor(
             (CallGeneratorParams params) -> {
+              // **NOTE**:
+              // The following "CallGeneratorParams" lambda merely generates a stateless
+              // HTTPs requests, the effective apiClient is the one specified when constructing
+              // the informer-factory.
               return coreV1Api.listNodeCall(
                   null,
                   null,

examples/examples-release-14/src/main/java/io/kubernetes/client/examples/InformerExample.java

@@ -41,12 +41,16 @@ public static void main(String[] args) throws Exception {
         apiClient.getHttpClient().newBuilder().readTimeout(0, TimeUnit.SECONDS).build();
     apiClient.setHttpClient(httpClient);
 
-    SharedInformerFactory factory = new SharedInformerFactory();
+    SharedInformerFactory factory = new SharedInformerFactory(apiClient);
 
     // Node informer
     SharedIndexInformer<V1Node> nodeInformer =
         factory.sharedIndexInformerFor(
             (CallGeneratorParams params) -> {
+              // **NOTE**:
+              // The following "CallGeneratorParams" lambda merely generates a stateless
+              // HTTPs requests, the effective apiClient is the one specified when constructing
+              // the informer-factory.
               return coreV1Api.listNodeCall(
                   null,
                   null,

examples/examples-release-15/src/main/java/io/kubernetes/client/examples/InformerExample.java

@@ -41,11 +41,15 @@ public static void main(String[] args) throws Exception {
         apiClient.getHttpClient().newBuilder().readTimeout(0, TimeUnit.SECONDS).build();
     apiClient.setHttpClient(httpClient);
 
-    SharedInformerFactory factory = new SharedInformerFactory();
+    SharedInformerFactory factory = new SharedInformerFactory(apiClient);
 
     // Node informer
     SharedIndexInformer<V1Node> nodeInformer =
         factory.sharedIndexInformerFor(
+            // **NOTE**:
+            // The following "CallGeneratorParams" lambda merely generates a stateless
+            // HTTPs requests, the effective apiClient is the one specified when constructing
+            // the informer-factory.
             (CallGeneratorParams params) -> {
               return coreV1Api.listNodeCall(
                   null,

util/src/main/java/io/kubernetes/client/informer/SharedInformerFactory.java

@@ -49,6 +49,8 @@ public class SharedInformerFactory {
   private ApiClient apiClient;
 
   /** Constructor w/ default thread pool. */
+  /** DEPRECATE: In favor of explicit apiClient constructor to avoid misguiding */
+  @Deprecated
   public SharedInformerFactory() {
     this(Configuration.getDefaultApiClient().setReadTimeout(0), Executors.newCachedThreadPool());
   }