Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for v21.0.0-legacy/v22.0.0-legacy Support #3866

Closed
LvWuqian opened this issue Jan 15, 2025 · 11 comments
Closed

Request for v21.0.0-legacy/v22.0.0-legacy Support #3866

LvWuqian opened this issue Jan 15, 2025 · 11 comments

Comments

@LvWuqian
Copy link

Hello,

With the changes in client-java-api version 20.0.0, certain features are not backward-compatible, and Java8 support has been dropped. For developers still using Java8, would it be possible to release a v21.0.0-legacy/v22.0.0-legacy version?

This would help those of us unable to switch to newer Java versions immediately.

Thank you for considering this request!

@rajathvkamath
Copy link

Hello Team,
+1 to consider this request. The latest legacy version shows an associated vulnerability - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-7254 . It will really help if you could provide plans for v22.0.0-legacy release. Thank you!

@brendandburns
Copy link
Contributor

I just kicked off a patch release for 21.0.2 hopefully that works.

We'll see about future versions, it is painful to have to carry both versions indefinitely, and Java8 is on the path to EOL quite soon.

@brendandburns
Copy link
Contributor

And fwiw, this vulnerability doesn't impact this library, given how we use proto buffers (and also given that most users use JSON not proto for communications w/ the API server)

@yue9944882
Copy link
Member

yue9944882 commented Jan 16, 2025

IIRC something is wrong with the author info for the generated commits from the workflow. I think we can tentatively suppress that error by using our personal github email to author the generated commits.. if that sounds good to you, i can edit the workflow accordingly

@yue9944882
Copy link
Member

https://github.com/kubernetes-client/java/actions/runs/12811928990/job/35722408324

the last run failed due to invalid input.. triggering a new one now

@yue9944882
Copy link
Member

#3870

@brendandburns The retry workflow failed again due to incorrect pom version on release-legacy-21 branch. We need to manually bump the version then retry..

@brendandburns
Copy link
Contributor

21.0.2-legacy is now available on Maven:

https://mvnrepository.com/artifact/io.kubernetes/client-java/21.0.2-legacy

@brendandburns
Copy link
Contributor

@yue9944882 we're going to need to manually update the POMs since sending PRs from a Github action is still broken :(

@yue9944882
Copy link
Member

fatal: unable to access 'https://github.com/kubernetes-client/java.git/': The requested URL returned error: 403

Yea the workflow is failing because we disabled GH action's write permission from the package..

Image

@yue9944882
Copy link
Member

To make this automated by workflow again, I will think we can do:

  1. Convince github org admins to re-open the write permission for this repo.
  2. Create (or re-use) a middleman release bot account to write the generated code into its own fork and then create a PR from there..

I will try reach out to the sig-contribex folks for more info..

@yue9944882
Copy link
Member

yue9944882 commented Jan 22, 2025

I ended up setting up then publishing 22.0.0-legacy from my forked repo due to the permission issue:

Workflow: https://github.com/yue9944882/java/actions/runs/12918918903/job/36028402568
Generated PR: yue9944882#100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants