Skip to content

Commit d17707d

Browse files
committed
Address comment
1 parent f5f6b33 commit d17707d

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/web-socket-handler.ts

-3
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,11 @@ export class WebSocketHandler implements WebSocketInterface {
4242
}
4343

4444
public static closeStream(streamNum: number, streams: StreamInterface): void {
45-
console.log('Closing stream: ' + streamNum);
4645
switch (streamNum) {
4746
case WebSocketHandler.StdinStream:
4847
streams.stdin.pause();
4948
break;
5049
case WebSocketHandler.StdoutStream:
51-
console.log('closing stdout');
5250
streams.stdout.end();
5351
break;
5452
case WebSocketHandler.StderrStream:
@@ -249,7 +247,6 @@ export class WebSocketHandler implements WebSocketInterface {
249247
} else if (data instanceof Buffer) {
250248
const streamNum = data.readUint8(0);
251249
if (streamNum === WebSocketHandler.CloseStream) {
252-
console.log('Closing stream!');
253250
WebSocketHandler.closeStream(data.readInt8(1), this.streams);
254251
}
255252
if (binaryHandler && !binaryHandler(streamNum, data.subarray(1))) {

src/web-socket-handler_test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { promisify } from 'util';
22
import { expect } from 'chai';
33
import WebSocket = require('isomorphic-ws');
44
import { ReadableStreamBuffer, WritableStreamBuffer } from 'stream-buffers';
5-
import stream = require('stream');
5+
import stream from 'node:stream';
66

77
import { V1Status } from './api';
88
import { KubeConfig } from './config';
@@ -401,7 +401,7 @@ describe('V5 protocol support', () => {
401401
stdinStream.emit('end');
402402
expect(sent).to.not.be.null;
403403
expect(sent!.readUint8(0)).to.equal(255); // CLOSE signal
404-
expect(sent!.readUInt8(1)).to.equal(0); // Stdin stream is #0
404+
expect(sent!.readUint8(1)).to.equal(0); // Stdin stream is #0
405405
});
406406
});
407407

0 commit comments

Comments
 (0)